[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnugo-devel] Bug: gnugo 3.6-pre2 (seed 551253403)

From: bump
Subject: Re: [gnugo-devel] Bug: gnugo 3.6-pre2 (seed 551253403)
Date: Sat, 2 Oct 2004 20:06:37 -0700

Trevor wrote:

> Perhaps pre3 is warranted, as there is known crash potential in pre2,
> that is compiler dependent.

Pre3 would be warranted if we had a fix for the crash. As
I wrote, I cannot reproduce it. Trevor, can you reproduce 
the crash?

Paul wrote:

> SGF code seems too broken to patch up this little leak.  I
> suggest we leave it be (for now.)  Also, I suggest that you
> apply the SGF fix to the 3.6 branch (if you haven't done this
> yet) because it can potentially prevent real bugs.

Your sgf patch is in the 3.6 branch. As for the memory leak, here is a
fix. The sgf node created by sgftreeCreateHeaderNode was not getting freed.
I have not added this to the CVS yet.


Index: interface/main.c
RCS file: /cvsroot/gnugo/gnugo/interface/main.c,v
retrieving revision
diff -u -r1.102.2.2 main.c
--- interface/main.c    2 Sep 2004 13:25:09 -0000
+++ interface/main.c    3 Oct 2004 02:59:52 -0000
@@ -1391,6 +1391,7 @@
   clock_report_autolevel(NULL, gameinfo.computer_player);
+  sgfFreeNode(gameinfo.game_record.root);
   return 0;
 }  /* end main */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]