Re: [Gnumed-bugs] GNUmed 1.3x mislabelling of Billing column "Charge date"

[Karsten Hilbert]

On Fri, May 10, 2013 at 08:22:23PM +0000, Jim Busser wrote:

> Actually there seems to be a bug here, because when I use the Billing
> 
>       Add button
> 
> and despite that the Encounter field allows me to use and
> select from a phrasewheel, and updates what was selected
> into the field display, when I save this dialog the front
> end ignores the encounter that I had selected and instead
> shows the current date as the charge date.

Confirmed. And sure enough:

        #----------------------------------------------------------------
        def _save_as_new(self):
                data = gmBilling.create_bill_item (
                        pk_encounter = 
gmPerson.gmCurrentPatient().emr.active_encounter['pk_encounter'],
                        pk_billable = self._PRW_billable.GetData(),
                        pk_staff = gmStaff.gmCurrentProvider()['pk_staff']      
        # should be settable !
                )
                data['raw_date_to_bill'] = self._PRW_date.GetData()
                ...
                data.save()

it defaults to the current encounter on saving ;-)

Fixed.

> When I edit the item, I no longer see the earlier
> encounter which I had selected (but failed to successfully
> save). Instead, I see the current encounter.

Dang, can't believe it but that's another bug right there.

        #----------------------------------------------------------------
        def _refresh_from_existing(self):
                ...
                
self._PRW_encounter.set_from_instance(gmPerson.gmCurrentPatient().emr.active_encounter)


Fixed as well.

Karsten
-- 
GPG key ID E4071346 @ gpg-keyserver.de
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346