[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: NSBrowser patch
From: |
David Ayers |
Subject: |
Re: NSBrowser patch |
Date: |
Sat, 28 Sep 2002 23:22:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826 |
Serg Stoyan wrote:
Hi everybody!
This a NSBrowser patch changes behaviour of setSeparatesColumns
method.
Very nice!
Here's minor suggestion.
Cheers,
Dave
--- NSBrowser.m.org Sat Sep 28 23:09:35 2002
+++ NSBrowser.m Sat Sep 28 23:16:49 2002
@@ -1099,6 +1099,7 @@
{
NSBrowserColumn *bc;
NSScrollView *sc;
+ NSBorderType bt;
int i, columnCount;
// if this flag already set or browser is titled -- do nothing
@@ -1106,28 +1107,17 @@
return;
columnCount = [_browserColumns count];
- if (flag)
- {
- for (i = 0; i < columnCount; i++)
- {
- bc = [_browserColumns objectAtIndex: i];
- sc = [bc columnScrollView];
- [sc setBorderType:NSBezelBorder];
- }
- }
- else
+ bt = flag ? NSBezelBorder : NSNoBorder;
+ for (i = 0; i < columnCount; i++)
{
- for (i = 0; i < columnCount; i++)
- {
- bc = [_browserColumns objectAtIndex: i];
- sc = [bc columnScrollView];
- [sc setBorderType:NSNoBorder];
- }
- }
-
- _separatesColumns = flag;
+ bc = [_browserColumns objectAtIndex: i];
+ sc = [bc columnScrollView];
+ [sc setBorderType:bt];
+ }
+
+ _separatesColumns = flag;
[self setNeedsDisplay:YES];
- [self tile];
+ [self tile];
}
/** Returns YES if the title of a column is set to the string value of
- NSBrowser patch, Serg Stoyan, 2002/09/27
- Re: NSBrowser patch,
David Ayers <=