[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Revised GUI patch
From: |
Adrian Robert |
Subject: |
Revised GUI patch |
Date: |
Fri, 15 Oct 2004 10:05:44 -0400 |
Hi,
I'm attaching a patch that contains the non-controversial, completed
parts of my earlier patch to GUI to get Emacs working, in cleaned up
form. Please consider this for commit. Also, I listed some pending
issues (from excluded portions of the original patch or otherwise)
below.
Source/Functions.m
NSBestDepth() - check outarg exactMatch for non-nil before setting.
Headers/AppKit/NSApplication.h
added instance variable '_app_is_launched'
Source/NSApplication.m
-setMainMenu: - make new menu visible after hiding old one
-run - only call -finishLaunching first time
Source/NSColorList.m
-initWithName:fromFile: - 'path' argument should not include
filename; change code to take account of
this but support inclusion (with
deprecation warning) for now; also,
support text color list file format, only
RGBA for now
Source/NSFont.m
getNSFont() - use defaultSize for 'fontSize' args of <0 as well as ==0
Headers/AppKit/NSScroller.h
added instance variable '_buttonsWidth'
Source/NSScroller.m
-initWithCoder: - init _buttonsWidth based on [isa scrollerWidth]
(not stored in archive)
-initWithFrame:, -checkSpaceForParts, -rectForPart - use
_buttonsWidth ivar in place of previous static
constant buttonsWidth
+ setControlSize: - return [isa scrollerWidth] instead of static
constant
Source/NSTabView.m
- removeTabViewItem: - remove item from display if it is selected;
set display to update if last tab removed
-drawRect: - don't select first tab if there are no tabs
STILL PENDING:
Source/NSColorList.m
-initWithName:fromFile: - Need to implement other reading of all
text color list file formats (awaiting
documentation on them).
Source/NSApplication.m
-run - [_listener updateServicesMenu] seems to be called on too many
events; a FIXME comment was put in, feedback is needed
Source/NSScroller.m
scroller button width is only scalable to a limited extent;
also, support for controlSize is not implemented
Source/NSEvent.m
-timestamp - seems to be returning milliseconds since system
startup, whereas Apple docs say it is seconds;
corresponding changes may be needed elsewhere
NSApplication and/or NSRunLoop
There seems to be a general problem in the event loop where poll()
in NSRunLoop is being called with long timeouts, and
NSApplicationDefined events that come in don't get picked up until
some keyboard or mouse event occurs. (Note, I am not sure this is a
fully accurate characterization of the problem. The SYMPTOM is that
the passing back-and-forth of the event loop in Emacs is not working
properly, though it works on OS X. See the README referenced on
http://kamares.ucsd.edu/~arobert/GNUstep/emacs.html for more
information.)
<gnustep-gui-0.94+_2.patch>
gnustep-gui-0.94+_2.patch
Description: Text Data
- Revised GUI patch,
Adrian Robert <=