Re: [Gnustep-cvs] r23599 - in /libs/gui/trunk: ChangeLog Source/NSTableView.m

[Matt Rice]

--- Fred Kiefer <address@hidden> wrote:

> HI Matt,
> 
> could you please explain this change? When writing
> this method I took
> great care to implement it the way Quentin did
> describe the behaviour of
> Cocoa in his mail from the 8th of September. Was the
> description wrong
> or just my implementation?
> 

I seem to have not recieved Quentin's description, and
can't find it in the archives, so can't comment on it

according to the documentation:
"The delegate can implement this method to disallow
editing of specific cells."

this says nothing of allowing inedible cells to become
editable, as it was implemented if a delegate did not
respond to tableView:shouldEditTableColumn:row: and a
table column was ineditable, it would allow editing

it ignored editable columns entirely always returning
yes, so it didn't actually allow you to do any
disallowing, 

anyhow according to my testing this was how it worked,

though maybe its changed in later releases, 

if it has changed and should allow editing of inedible
columns it should probably be rolled into
_shouldEdit... and return [tableColumn isEditable] for
the case where the delegate doesn't respond

> Cheers
> Fred
> 
> matt rice schrieb:
> > Author: ratmice
> > Date: Sat Sep 23 23:53:25 2006
> > New Revision: 23599
> > 
> > URL:
>
http://svn.gna.org/viewcvs/gnustep?rev=23599&view=rev
> > Log:
> >        * Source/NSTableView.m
> (_isCellEditableColumn:row:): Allow
> >        delegate to limit editablility of editable
> columns.
> > 
> > 
> > Modified:
> >     libs/gui/trunk/ChangeLog
> >     libs/gui/trunk/Source/NSTableView.m
> > 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com