[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: drawTitle:withFrame:inView... should it return NSRect...
From: |
Fred Kiefer |
Subject: |
Re: drawTitle:withFrame:inView... should it return NSRect... |
Date: |
Wed, 20 Aug 2014 22:54:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
The suggested change is fine by me. I already broke the ABI when I
corrected the values in externs.m.
Fred
On 19.08.2014 11:26, David Chisnall wrote:
> Note that changing from void return to struct return will change the
> parameter order (the first integer argument register will be the
> return address, not the receiver), which will break the ABI. We'll
> need to bump the so version if we do this.
>
> The GNUstep runtime will give you a warning / error (depending on how
> it is compiled) if you have headers and implementations mismatched
> for this. The GCC and Apple runtimes will corrupt your stack.
>
> David
>
> On 18 Aug 2014, at 21:31, Gregory Casamento
> <address@hidden> wrote:
>
>> Our current implementation is declared as such:
>>
>> - (void) drawTitle: (NSAttributedString*)titleToDisplay withFrame:
>> (NSRect)cellFrame inView: (NSView*)controlView
>>
>> https://developer.apple.com/library/mac/documentation/cocoa/reference/applicationkit/classes/NSButtonCell_Class/Reference/Reference.html#//apple_ref/occ/instm/NSButtonCell/drawTitle:withFrame:inView:
>>
>>
>>
The version in the documentation returns NSRect.
>>
>> Should we change ours to do this as well? Any opinions?
>>
>> Thanks, GC