[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coverity Scan for GNUstep?
From: |
Ivan Vučica |
Subject: |
Re: Coverity Scan for GNUstep? |
Date: |
Wed, 24 Jan 2018 23:59:25 +0000 |
On Wed, Jan 24, 2018 at 11:56 PM, Ivan Vučica <address@hidden> wrote:
> On Mon, Jan 22, 2018 at 10:23 PM, Fred Kiefer <address@hidden> wrote:
>>
>>
>> In the meantime my connection with GNUstep has been confirmed and I was
>> able to look at the found issues. Many of them are false positives mostly
>> caused by Coverity expecting normal program continuation after NSException
>> raise.
>
> Some of this type of issues can be fixed with __attribute__ ((noreturn)).
>
> Manual says "The attribute noreturn is not implemented in GCC versions
> earlier than 2.5." which is older than what we support, so it should
> be fine.
>
> Even though it's just silencing this warning, I'm nonetheless creating
> a patch for gdomap.
Please disregard the mention of creating a patch for gdomap.c.
I've taken a closer look only a few seconds after posting this and it
looks like gdomap_log exits only sometimes, so the 'breaks are
missing' warning is probably correct.
I won't be creating the patch adding noreturn.
>> Even so it did detect a few potential issues in base. I flagged some of the
>> false positives so the more interesting bits are left over for somebody to
>> look at. Especially the „time of check, time of use“ issues should be looked
>> at.
>>
>> Fred
>> _______________________________________________
>> Gnustep-dev mailing list
>> address@hidden
>> https://lists.gnu.org/mailman/listinfo/gnustep-dev
- Re: Coverity Scan for GNUstep?, (continued)
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/21
- Re: Coverity Scan for GNUstep?, David Chisnall, 2018/01/21
- Re: Coverity Scan for GNUstep?, Ivan Vučica, 2018/01/21
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/21
- Re: Coverity Scan for GNUstep?, Ivan Vučica, 2018/01/21
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/21
- Re: Coverity Scan for GNUstep?, David Chisnall, 2018/01/22
- Re: Coverity Scan for GNUstep?, Patryk Laurent, 2018/01/21
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/22
- Re: Coverity Scan for GNUstep?, Ivan Vučica, 2018/01/24
- Re: Coverity Scan for GNUstep?,
Ivan Vučica <=
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/25
- Re: Coverity Scan for GNUstep?, Richard Frith-Macdonald, 2018/01/25
- Re: Coverity Scan for GNUstep?, David Chisnall, 2018/01/25
- Re: Coverity Scan for GNUstep?, Richard Frith-Macdonald, 2018/01/29
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/29
- Re: Coverity Scan for GNUstep?, Richard Frith-Macdonald, 2018/01/29
- Re: Coverity Scan for GNUstep?, Ivan Vučica, 2018/01/29
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/29
- Re: Coverity Scan for GNUstep?, Wolfgang Lux, 2018/01/29
- Re: Coverity Scan for GNUstep?, Fred Kiefer, 2018/01/29