Re: [PATCH 0/3] gnustep-make: stage 1 of cross-compile awareness

[Wolfgang Lux]

> Am 12.01.2020 um 23:23 schrieb Fred Kiefer <address@hidden>:
> 
> Thank you for your patches. The first two are clear improvements. The third 
> one also looks good to me, but I must admit it is really hard to read through 
> in a patch mail (and I only read the configure.ac part. After the merge I 
> would regenerate configure locally). As far as I can tell you mostly moved 
> things around and unified the compiler checks to always use  ${CLANG_CC}.
> I am not sure whether we will need a copyright assignment for these patches. 
> The changes themselves are not that big but it might be better if you sign 
> one.

I'm sorry, but with regard to the second patch (Fix GNU Make detection) I feel 
I must disagree that it's an improvement. From a cursory look it, it seems that 
this change falls short of the common mistake to assume that /bin/sh is 
/bin/bash, which simply is not true (not even for Linux, look at Debian). The 
parameter substitutions
 MAJOR_MAKE_VERSION="${MAKE_VERSION%%.*}"
 MINOR_MAKE_VERSION="${MAKE_VERSION#*.}"
 MINOR_MAKE_VERSION="${MINOR_MAKE_VERSION%%.*}"
are prone to fail on most shells other than bash.

Wolfgang