[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.15-56-g51916a1

[Jon Schlueter]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GPSD".

The branch, master has been updated
       via  51916a197a0a4d88938e1bf7dfa6136b0cc29bce (commit)
       via  ddcc52b5541ed662ecb8399a364a3eb5b6234a32 (commit)
      from  ee67d00957fa58527f33cd1772ae8c05c317db15 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 51916a197a0a4d88938e1bf7dfa6136b0cc29bce
Author: Jon Schlueter <address@hidden>
Date:   Wed Oct 7 21:32:57 2015 -0400

    whitespace cleanup in sample.aivdm*.chk files

commit ddcc52b5541ed662ecb8399a364a3eb5b6234a32
Author: Jon Schlueter <address@hidden>
Date:   Wed Oct 7 21:29:30 2015 -0400

    AIS: Add better handling of non byte aligned data blobs
    
    I ran into a problem with the type 8 unstructured data. When the number
    of bits available is not dividable by 8, the last byte may contain
    random bits. I would expect the bits beyond the valid range to be 0.
    
    An example of this can be found in the following message:
    !AIVDM,3,1,4,A,85PH6TAKfDOkp95`nCRt5w<:qFUiaihFhBc7s4AHGsQ,0*40
    !AIVDM,3,2,4,A,DcMJM18k6<=m7rwVm3b5RRWEskwJWej8uP<0:W5K6PA,0*61
    !AIVDM,3,3,4,A,gPs<dwulp,4*14
    
    The current version decodes this to:
    
    
{"class":"AIS","device":"stdin","type":8,"repeat":0,"mmsi":369493649,"scaled":true,"dac":366,"fid":57,"data":"510:47f3e09168d938bc17f30ae56971a71c16c12ac7ec44585fb854add69d048cc630dd47ebf9b50ea1628a757bcff6a7b7223d80c00a9c56c6811be0eccb3ff74e"}
    
    The 510 bits of data are 63 full bytes and then 6 remaining bits. The
    last byte has value: 4e, which is 0100 1110. I would expect 4c, 0100 1100.
    
    To fix this, the following patch could be applied. Please note that the
    problem might also be present in other message types, but I have not
    encountered any problems in other message types in the 1 million
    messages I have in my test dataset. Message types that could be impacted
    are: 6, 17, 25 and 26, as they all use the same memcpy to get
    unstructured data.
    
    Identified by: Stefan Roels <address@hidden>
    
    Added new sample entry to sample.aivdm that exercises this case
    Had to regenerate large ais test data log

-----------------------------------------------------------------------

Summary of changes:
 driver_ais.c                        |   14 ++++++++++----
 test/daemon/ais-nmea-sample.log.chk |    4 ++--
 test/sample.aivdm                   |    6 ++++++
 test/sample.aivdm.chk               |    3 ++-
 test/sample.aivdm.js.chk            |    1 +
 test/sample.aivdm.ju.chk            |    3 ++-
 6 files changed, 23 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
GPSD