[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-75-
From: |
Jon Schlueter |
Subject: |
[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-75-g722e440 |
Date: |
Tue, 01 Mar 2016 01:00:27 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GPSD".
The branch, master has been updated
via 722e44036fbc520399c8dab1d524489b3b9cabee (commit)
via 717d8d0651376e77664017f6a57f3fbab782ec8a (commit)
via 698e974c99d4acf5bdc4d0cb8a8f7f2127ee865b (commit)
from f51c4031ee41087840e9f14a1315e101bbea59f1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 722e44036fbc520399c8dab1d524489b3b9cabee
Author: Fred Wright <address@hidden>
Date: Sun Feb 28 14:24:52 2016 -0800
Eliminates spurious gpsd errors with gpsfake in TCP mode.
Depending on timing, in TCP mode, gpsd may try to reconnect to fake.py
between the time that the logfile is complete and the time that the
remove_device is issued. With no listener, this results in a set of
three error messages from gpsd. They don't affect the test outcome,
since they only go to stderr and the "real" output is complete, but
they're annoying to the user.
The likelihood of this happening increases with longer logfiles and
with larger WRITE_PAD values. With a 30ms WRITE_PAD (the default on
OSX), most logfiles exhibit this on all platforms, though it's not
seen on Linux with the default zero WRITE_PAD.
The fix is simply to avoid closing the listener after accepting the
incoming connection. It's not necessary to explicitly service the
listener further, since the OS listen queue is sufficient to accept
the additional connection.
Closing the listener at drain time is almost acceptable, but still
occasionally fails due to the fact that drain() is (necessarily)
called before remove_device(). Not explicitly closing it at all is
acceptable, since Python closes it as part of the object cleanup.
TESTED:
Ran regress-driver in TCP mode with a 30ms WRITE_PAD on all logfiles
on three versions of OSX, as well as Linux, FreeBSD, and OpenBSD, both
with and without the fix. Observed spurious errors in all cases
without the fix, and no cases with the fix. Also verified that no
dangling sockets were left at the end of the runs.
commit 717d8d0651376e77664017f6a57f3fbab782ec8a
Author: Fred Wright <address@hidden>
Date: Fri Feb 26 17:05:53 2016 -0800
Makes testclean more complete and effective.
This replaces the hard-coded (and incomplete) list of test executables
to remove with a list derived from testprogs. It also adds the
corresponding object files to the list.
TESTED:
Verified that the 'check' works properly, with more complete cleanup.
commit 698e974c99d4acf5bdc4d0cb8a8f7f2127ee865b
Author: Fred Wright <address@hidden>
Date: Fri Feb 26 16:33:23 2016 -0800
Adds 'test-nondaemon' and 'test-noclean' targets.
The 'test-nondaemon' target provides a convenient way to run all but
the really time-consuming tests, also without removing the tests via
'testclean'.
The 'test-noclean' target runs all tests, but doesn't run 'testclean'.
Skipping 'testclean' not only avoids gratuitous rebuilds when running
tests multiple times, but also works properly when parallelized.
Note, however, that the value of parallelizing 'test-noclean' is
currently limited by the serialization of the daemon tests.
TESTED:
Verified that old and new test targets work as expected, as well as
the default build.
-----------------------------------------------------------------------
Summary of changes:
SConstruct | 18 +++++++++++++-----
gps/fake.py | 7 ++++++-
2 files changed, 19 insertions(+), 6 deletions(-)
hooks/post-receive
--
GPSD
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-75-g722e440,
Jon Schlueter <=