gpsd-commit-watch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-534


From: Fred Wright
Subject: [gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-534-gc153026
Date: Fri, 6 Jan 2017 01:34:11 +0000 (UTC)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GPSD".

The branch, master has been updated
       via  c1530269368964931868e2d0d3422cbaf7c85f76 (commit)
      from  99b3b3a2e642a3f182392c69512da35157f40ac3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c1530269368964931868e2d0d3422cbaf7c85f76
Author: Fred Wright <address@hidden>
Date:   Thu Jan 5 17:27:21 2017 -0800

    Fixes Mach port leak in OSX clock_gettime fallback.
    
    The commonly circulated code for nanosecond-resolution time of day in
    OSX has a bug.  The port obtained by mach_host_self() is a resource
    which needs to be freed after use.  This issue has been observed in
    connection with a different Mach port use in:
    
         https://codereview.chromium.org/279293002/
    
    It's not known how long one has to run gpsd in order to run afoul of
    this bug, or whether it has been observed in practice, but fixing it
    proactively is wise.  Note that this code disappears in macOS >=10.12,
    once native clock_gettime finally appeared.
    
    Also note that the host port is only needed to *obtain* the clock
    port, not to *use* the clock port, so it can be freed prior to
    actually reading the clock.
    
    TESTED:
    Ran "scons build-all check" on OSX 10.5-10.12.
    Ran gpsd for a few hours on OSX 10.9.5 (with one receiver).

-----------------------------------------------------------------------

Summary of changes:
 clock_gettime.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
GPSD



reply via email to

[Prev in Thread] Current Thread [Next in Thread]