groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 09/10: [troff]: Remove workaround for Cfront 1.2 bug.


From: G. Branden Robinson
Subject: [groff] 09/10: [troff]: Remove workaround for Cfront 1.2 bug.
Date: Mon, 6 Sep 2021 15:01:26 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit 38fb22fd56bc9355a78a73fc7a6c97713eecad35
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Mon Sep 6 04:38:24 2021 +1000

    [troff]: Remove workaround for Cfront 1.2 bug.
    
    * src/roff/troff/input.cpp (do_define_macro): Move `dot_symbol` from to
      file to function local scope as originally intended.
    
    "Cfront 4.0 was abandoned in 1993 after a failed attempt to add
    exception support." -- Wikipedia
    
    Surely no one still uses that compiler.
---
 ChangeLog                | 7 +++++++
 src/roff/troff/input.cpp | 5 +----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 600599a..7d6f125 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2021-09-06  G. Branden Robinson <g.branden.robinson@gmail.com>
 
+       [troff]: Remove workaround for Cfront 1.2 bug.
+
+       * src/roff/troff/input.cpp (do_define_macro): Move `dot_symbol`
+       from to file to function local scope as originally intended.
+
+2021-09-06  G. Branden Robinson <g.branden.robinson@gmail.com>
+
        [troff]: Rename parameter.
 
        * src/roff/troff/input.cpp (token::usable_as_delimiter): Rename
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 43fdac9..8e1cdbf 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -4456,12 +4456,9 @@ void handle_initial_title()
   handle_initial_request(TITLE_REQUEST);
 }
 
-// this should be local to define_macro, but cfront 1.2 doesn't support that
-static symbol dot_symbol(".");
-
 void do_define_macro(define_mode mode, calling_mode calling, comp_mode comp)
 {
-  symbol nm, term;
+  symbol nm, term, dot_symbol(".");
   if (calling == CALLING_INDIRECT) {
     symbol temp1 = get_name(true /* required */);
     if (temp1.is_null()) {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]