[groff] 01/01: [gropdf]: Drop pdfmom's new '-roff' option.

[G. Branden Robinson]

gbranden pushed a commit to branch post-1.23.0
in repository groff.

commit 689f2bfa3cbbbde6be68ddf6717264ab1144ee20
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Thu Mar 16 22:15:03 2023 -0500

    [gropdf]: Drop pdfmom's new '-roff' option.
    
    ...retaining '--roff'.
    
    '-roff' syntactically collides with the groff option '-roff', which
    creates a register named 'o' with the value 'ff' (which is rejected
    because it is not in a numeric format).  While the two uses can be
    distinguished on this basis alone, in my opinion it makes the waters to
    murky.  (In the event GNU troff learned to interpret hexadecimal number
    format, it would then be a serious collision.)
    
    * src/devices/gropdf/pdfmom.pl: Do it.
    * src/devices/gropdf/pdfmom.1.man: Document the double-dash form
      exclusively.
    
    Also fix style and content nits in the explanation of this mode of
    operation in pdfmom(1).
---
 ChangeLog                       | 16 ++++++++++++++++
 src/devices/gropdf/pdfmom.1.man | 25 +++++++++++++++----------
 src/devices/gropdf/pdfmom.pl    |  2 +-
 3 files changed, 32 insertions(+), 11 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6187cbd9d..f8a546336 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
+2023-03-16  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [gropdf]: Drop pdfmom's new '-roff' option, retaining '--roff'.
+
+       '-roff' syntactically collides with the groff option '-roff',
+       which creates a register named 'o' with the value 'ff' (which is
+       rejected because it is not in a numeric format).  While the two
+       uses can be distinguished on this basis alone, in my opinion it
+       makes the waters to murky.  (In the event GNU troff learned to
+       interpret hexadecimal number format, it would then be a serious
+       collision.)
+
+       * src/devices/gropdf/pdfmom.pl: Do it.
+       * src/devices/gropdf/pdfmom.1.man: Document the double-dash form
+       exclusively.
+
 2023-03-16  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * src/libs/libxutil/XFontName.c (utoa): Rename function from
diff --git a/src/devices/gropdf/pdfmom.1.man b/src/devices/gropdf/pdfmom.1.man
index 64176cd03..1bbaaaf70 100644
--- a/src/devices/gropdf/pdfmom.1.man
+++ b/src/devices/gropdf/pdfmom.1.man
@@ -10,7 +10,7 @@ macro package for
 .\" Legal Terms
 .\" ====================================================================
 .\"
-.\" Copyright (C) 2012-2020 Free Software Foundation, Inc.
+.\" Copyright (C) 2012-2023 Free Software Foundation, Inc.
 .\"
 .\" Permission is granted to make and distribute verbatim copies of this
 .\" manual provided the copyright notice and this permission notice are
@@ -53,14 +53,15 @@ macro package for
 .\" ====================================================================
 .
 .SY pdfmom
+.RB [ \-\-roff ]
 .RB [ \-Tpdf ]
-.RB [ \-roff ]
 .RI [ groff-options ]
 .RI [ file\~ .\|.\|.]
 .YS
 .
 .
 .SY pdfmom
+.RB [ \-\-roff ]
 .B \-Tps
 .RI [ pdfroff-options ]
 .RI [ groff-options ]
@@ -91,17 +92,21 @@ macros.
 .
 .P
 If the
-.B \-roff
-option is used the link to
-.I mom
-is severed and the wrapper can be used with other macro sets.
+.B \-\-roff
+option is used,
+the wrapper can be used with macro packages other than
+.MR groff_mom @MAN7EXT@ .
+.
 This is also true if the wrapper is renamed or linked as a
-pseudonym, so creating a link called
+pseudonym;
+for example,
+creating a
 .I pdfms
-which targets pdfmom will create a wrapper for creating pdfs
-with the
+link pointing to the
+.I pdfmom
+executable makes a wrapper for producing PDFs with the
 .I ms
-macro.
+package.
 .
 .
 .P
diff --git a/src/devices/gropdf/pdfmom.pl b/src/devices/gropdf/pdfmom.pl
index 3a410d8ad..93a04410f 100644
--- a/src/devices/gropdf/pdfmom.pl
+++ b/src/devices/gropdf/pdfmom.pl
@@ -86,7 +86,7 @@ while (my $c=shift)
        $dev=$c;
        next;
     }
-    elsif ($c eq '-roff' or $c eq '--roff')
+    elsif ($c eq '--roff')
     {
         $mom='';
     }