grub-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: UFS (FFS) support seems broken in grub2

From: Marco Gerards
Subject: Re: UFS (FFS) support seems broken in grub2
Date: Wed, 23 Jan 2008 10:02:41 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) 
Robert Millan <address@hidden> writes:

> On Wed, Jan 23, 2008 at 02:58:02AM +0800, Bean wrote:
>> This patch should fix the problem.
>
> Nice!
>
>> -grub_ufs_label (grub_device_t device __attribute ((unused)),
>> -            char **label __attribute ((unused)))
>> +grub_ufs_label (grub_device_t device,char **label)
>
> Please add a space after the comma ;-)

And a changelog entry ;-)

--
Marco
reply via email to
[Prev in Thread] Current Thread [Next in Thread]