[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio tra
From: |
Robert Millan |
Subject: |
Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection |
Date: |
Wed, 6 Feb 2008 20:18:52 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Wed, Feb 06, 2008 at 03:29:45PM +0800, Bean wrote:
> > This patch fixes both issues.
>
> Actually, the first version of grub_cpio_find_file returned
> GRUB_ERR_FILE_NONE when the end of file is encounter, but then,
> somebody find out that opening non existent file have problem, and the
> result is changed to GRUB_ERR_FILE_NOT_FOUND. I guess it still have
> problem, the fix you are providing seems ok.
Christian doesn't have write perms. Bean, since you're more familiar with
this code, will you check that in?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)