Re: [PATCH] Journal support for ext2

[Yoshinori K. Okuji]

On Monday 18 February 2008 00:25, Bean wrote:
> Some adjustment in this patch: as the get_block function is only used
> when journal type is GRUB_FSHELP_JOURNAL_TYPE_FILE, i move it to
> grub_fshelp_journal instead of using it as a parameter for
> grub_fshelp_map_block. also add changelog for reiserfs.c.

Thanks for your effort. However, I don't like one part. It is about types. 
Although I understand why you did this way, it is not a good thing that you 
use "int" for block addressing. This is a fundamental issue in fshelp. 
Because of this, filesystem support is not 64-bit safe.

I don't urge you to fix everything, but please don't increase the mess.

Okuji