[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix GRUB_TICKS_PER_SECOND in include/grub/efi/time.h
From: |
Alexandre Boeglin |
Subject: |
Re: [PATCH] fix GRUB_TICKS_PER_SECOND in include/grub/efi/time.h |
Date: |
Fri, 22 Feb 2008 08:49:52 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
Le jeu 21 fév 2008 à 22:08:55 +0100, Yoshinori K. Okuji a écrit :
> On Sunday 17 February 2008 12:52, Alexandre Boeglin wrote:
> > This small patch fixes grub_get_rtc on EFI architecture. If I understood
> > correctly, one minute is 60000 milliseconds, not 3600.
>
> Nope. What's wrong here is the comment but not the code. It should read "This
> is destined to overflow when one hour passes by."
Then, I think the problem is the same, as the current grub_get_rtc returns a
number of milliseconds. So, shouldn'it be 60 * 60 * 1000 ?
Alex