Re: [PATCH] add a counter in grub_dprintf

[Marco Gerards]

Robert Millan <address@hidden> writes:

> How about adding a counter to grub_dprintf to make it easy to instrument
> GRUB and find which are the bottlenecks in boot time?
>
> Sidenote: perhaps it'd be a good idea to conditionalize all grub_dprintf
> calls with #ifdef DEBUG to obtain a smaller core.img.  It's not hard to
> ask a user to rebuild if dprintf is needed, and we can find non-ugly ways
> to do this without massive #ifdefs all over the code.

How about a configure time switch to *disable* dprintf.  I prefer to
have it enabled by default.  In that case distributions can create two
packages.  One for normal use and one for debugging.

--
Marco