grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Warning fixes


From: Pavel Roskin
Subject: [PATCH] Warning fixes
Date: Wed, 06 Aug 2008 09:39:02 -0400

Hello!

I've fixed the trivial stuff, but this may require comments.  I'll be
mostly offline for the next 3 weeks, so if it's OK, please apply it for
me.

ChangeLog:

        * disk/ata.c (grub_ata_pciinit): Mark pciid unused.
        * commands/i386/pc/pxecmd.c (grub_cmd_pxe): Mark argc and args
        unused.
        * include/grub/i386/pc/pxe.h (grub_pxenv_tftp_open): Use char
        instead of grub_uint8_t for strings.
        (grub_pxenv_tftp_get_fsize): Likewise.

Index: disk/ata.c
===================================================================
--- disk/ata.c  (revision 1784)
+++ disk/ata.c  (working copy)
@@ -429,7 +429,8 @@
 }
 
 static int
-grub_ata_pciinit (int bus, int device, int func, grub_pci_id_t pciid)
+grub_ata_pciinit (int bus, int device, int func,
+                 grub_pci_id_t pciid __attribute__ ((unused)))
 {
   static int compat_use[2] = { 0 };
   grub_pci_address_t addr;
Index: include/grub/i386/pc/pxe.h
===================================================================
--- include/grub/i386/pc/pxe.h  (revision 1784)
+++ include/grub/i386/pc/pxe.h  (working copy)
@@ -236,7 +236,7 @@
   grub_uint16_t status;
   grub_uint32_t server_ip;
   grub_uint32_t gateway_ip;
-  grub_uint8_t filename[128];
+  char filename[128];
   grub_uint16_t tftp_port;
   grub_uint16_t packet_size;
 } __attribute__ ((packed));
@@ -259,7 +259,7 @@
   grub_uint16_t status;
   grub_uint32_t server_ip;
   grub_uint32_t gateway_ip;
-  grub_uint8_t filename[128];
+  char filename[128];
   grub_uint32_t file_size;
 } __attribute__ ((packed));
 
Index: commands/i386/pc/pxecmd.c
===================================================================
--- commands/i386/pc/pxecmd.c   (revision 1784)
+++ commands/i386/pc/pxecmd.c   (working copy)
@@ -46,7 +46,9 @@
 }
 
 static grub_err_t
-grub_cmd_pxe (struct grub_arg_list *state, int argc, char **args)
+grub_cmd_pxe (struct grub_arg_list *state,
+             int argc __attribute__ ((unused)),
+             char **args __attribute__ ((unused)))
 {
   if (! grub_pxe_pxenv)
     return grub_error (GRUB_ERR_FILE_NOT_FOUND, "no pxe environment");

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]