grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix infinite loop in grub_pit_wait()


From: Christian Franke
Subject: Re: [PATCH] Fix infinite loop in grub_pit_wait()
Date: Thu, 07 Aug 2008 21:46:28 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11

Marco Gerards wrote:
Christian Franke <address@hidden> writes:

...
        (grub_pit_wait): Add enable/disable of the timer2 gate
        bit of port 0x61. This fixes a possible infinite loop.

Small nitpick: use a double space

...
+
+  /* Disable timer2 gate and speaker.  */
+  grub_outb (grub_inb (TIMER2_REG_LATCH) & ~ (TIMER2_SPEAKER | TIMER2_GATE), 
TIMER2_REG_LATCH);
These lines are too long, please break them properly.


Included in commit. Thanks.

Christian





reply via email to

[Prev in Thread] Current Thread [Next in Thread]