[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the lo
From: |
Marco Gerards |
Subject: |
Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader |
Date: |
Sat, 16 Aug 2008 16:50:17 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Robert Millan <address@hidden> writes:
> On Wed, Aug 13, 2008 at 07:52:59PM +0200, Marco Gerards wrote:
>> > #include <grub/types.h>
>> > #include <grub/symbol.h>
>> > +#include <grub/multiboot.h> /* For struct grub_mmap_entry, which is
>> > also
>> > + needed by Multiboot. */
>>
>> Isn't it better to split the header file? This seems like a hack.
>
> The definition is part of the Multiboot spec, so it really needs to be present
> in multiboot.h.
>
> We could also define it separately as grub_mmap_entry in multiboot.h and keep
> the grub_machine_mmap_entry definition in pc/init.h. Then other arches could
> have their own grub_machine_mmap_entry variant which _does_ differ from
> grub_mmap_entry (like coreboot).
>
> What do you think?
This sounds fine to me.
>> > Index: loader/i386/pc/multiboot.c
>> > ===================================================================
>> > --- loader/i386/pc/multiboot.c (revision 1802)
>> > +++ loader/i386/pc/multiboot.c (working copy)
>> > @@ -78,14 +78,60 @@
>> > grub_free ((void *) mbi->cmdline);
>> > grub_free (mbi);
>> > }
>> > -
>> > -
>> > +
>>
>> Hm? :-)
>
> Some minor janitor work ;-)
:-)
--
Marco
- [PATCH] decouple mmap parsing by using grub_available_iterate(), Robert Millan, 2008/08/11
- Re: [PATCH] decouple mmap parsing by using grub_available_iterate(), Vesa Jääskeläinen, 2008/08/11
- Re: [PATCH] decouple mmap parsing by using grub_available_iterate(), Robert Millan, 2008/08/11
- Re: [PATCH] decouple mmap parsing by using grub_available_iterate(), Robert Millan, 2008/08/11
- [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader, Robert Millan, 2008/08/12
- Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader, Robert Millan, 2008/08/12
- Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader, Robert Millan, 2008/08/12
- Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader, Robert Millan, 2008/08/12
- Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader, Marco Gerards, 2008/08/13
- Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader, Robert Millan, 2008/08/13
- Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader,
Marco Gerards <=
- Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader, Robert Millan, 2008/08/17