[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Replace magic numbers by constants
From: |
Marco Gerards |
Subject: |
Re: [PATCH] Replace magic numbers by constants |
Date: |
Sun, 17 Aug 2008 16:12:02 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Hi,
Carles Pina i Estany <address@hidden> writes:
> When I did the Home/End keys patch I noticied that in normal/menu.c
> there was some magic numbers (and some constants was already defined, in
> include/grub/term.h (actually, reading the ChangeLog was committed by
> Robert Millan on 2008-02-05)
>
> I'm sending a patch to change the magic numbers by constants.
>
> ChangeLog:
> --------
> 2008-08-17 Carles Pina i Estany <address@hidden>
>
> * menu/normal.c (run_menu): Change magic numbers by constants.
Can you be more specific about what you replace?
Thanks,
Marco
- [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants,
Marco Gerards <=
- Re: [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants, Robert Millan, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/20
- Re: [PATCH] Replace magic numbers by constants, Robert Millan, 2008/08/20
- Re: [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/20