grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix disk->id abuse


From: Pavel Roskin
Subject: Re: [PATCH] fix disk->id abuse
Date: Sat, 30 Aug 2008 11:41:18 -0400
User-agent: Internet Messaging Program (IMP) H3 (4.1.4)

Quoting Robert Millan <address@hidden>:

So this patch means to solve both issues;  makes single-disk drivers use a
constant directly (since a pointer to string is meaningless and confusing),
and disk/scsi.c use LUNs which (I believe) will work as unique identifiers.

Multi-character constants cause warnings. That's why I changed them to strings. Pointers to different strings are different, and that's all we need. If you prefer numeric IDs, perhaps we'll need a header file with all IDs we support. Alternatively, we need a macro that would convert characters to an ID.

--
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]