[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] support of hfsx ( case comparaison )
From: |
Michael Scherer |
Subject: |
Re: [PATCH] support of hfsx ( case comparaison ) |
Date: |
Wed, 03 Jun 2009 09:56:15 +0200 |
Le lundi 01 juin 2009 à 12:11 +0200, Vladimir 'phcoder' Serbinenko a
écrit :
> On Sun, May 3, 2009 at 7:19 PM, Michael Scherer <address@hidden> wrote:
> >
> > Le 7 févr. 09 à 22:02, Robert Millan a écrit :
> >
> >> On Mon, Jan 12, 2009 at 10:52:48PM +0100, Michael Scherer wrote:
> >>>
> >>> Hi,
> >>>
> >>> Here is the second patch, for hfsx support. This patch replace the
> >>> precedent.
> >>>
> >>> It is slightly more complex, and I didn't tested it on hfsx as I do
> >>> not have a proper partition.
> >>> But so far, it detect correctly config file on hfsplus.
> >>
> >> Hi,
> >>
> >> Thanks for your contribution. Would you be willing to assign copyright to
> >> the FSF for this? If you're fine with it, please let the FSF copyright
> >> clerk (CCed) know so he can send you the form.
> >
> >
> > Thanks to some postal problems, it took some months to get the copyright
> > assignement
> > to me. So, now it is over and I think you can apply the patch, I have
> > rediffed against latest svn.
> >
> > I tried to test it again, just in case, but grub is failling with "menuentry
> > , command not found." I will investigate a little
> > bit more.
> >
> Hello, thank you for your contribution
Well, thanks for taking time to review :)
> static int
> +grub_hfsplus_is_case_insentive (struct grub_hfsplus_data *data)
> +{
> You can declare this function as inline. This way you also doesn't
> need to temporarily save its result for performance
Indeed, here is a new patch.
Just for my own curiosity, isn't the inlining of function automatic with
gcc and recent compiler ?
> @@ -218,6 +228,7 @@ struct grub_hfsplus_data
> /* This is the offset into the physical disk for an embedded HFS+
> filesystem (one inside a plain HFS wrapper). */
> int embedded_offset;
> + int catalog_cmp_key;
> Where is this used? I see that you set it to a value but don't see you
> actually using it
in grub_hfsplus_is_case_insentive, in the case of GRUB_HFSPLUSX_MAGIC :
+ case GRUB_HFSPLUSX_MAGIC:
+ return data->catalog_cmp_key == GRUB_HFSPLUSX_CASEFOLDING;
--
Michael Scherer
grub-hfsplus.diff
Description: Text Data
- Re: [PATCH] support of hfsx ( case comparaison ), Vladimir 'phcoder' Serbinenko, 2009/06/01
- Re: [PATCH] support of hfsx ( case comparaison ),
Michael Scherer <=
- Re: [PATCH] support of hfsx ( case comparaison ), Vladimir 'phcoder' Serbinenko, 2009/06/03
- Re: [PATCH] support of hfsx ( case comparaison ), Michael Scherer, 2009/06/03
- Re: [PATCH] support of hfsx ( case comparaison ), Pavel Roskin, 2009/06/03
- Re: [PATCH] support of hfsx ( case comparaison ), Michael Scherer, 2009/06/05
- Re: [PATCH] support of hfsx ( case comparaison ), Vladimir 'phcoder' Serbinenko, 2009/06/05
- Re: [PATCH] support of hfsx ( case comparaison ), Pavel Roskin, 2009/06/06
- Re: [PATCH] support of hfsx ( case comparaison ), Vladimir 'phcoder' Serbinenko, 2009/06/07
- Re: [PATCH] support of hfsx ( case comparaison ), Pavel Roskin, 2009/06/07
- Re: [PATCH] support of hfsx ( case comparaison ), Pavel Roskin, 2009/06/05