[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] probe command
From: |
Pavel Roskin |
Subject: |
Re: [PATCH] probe command |
Date: |
Tue, 09 Jun 2009 15:23:48 -0400 |
On Tue, 2009-06-09 at 20:23 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Following Pavel's suggestion to make uuid command I implemented probe
> command similar to grub-probe
Great! Please remove trailing whitespace. Please add missing space
after "=" on line 64 in probe.c.
The help doesn't look right (no space before "print filesystem module").
I can have a look how to fix it if you don't find a way. Actually, I
would prefer separate options for targets, as in "search". That would
be:
-l --label
-u --fs_uuid
-p --partmap
-d --driver (instead of "provider")
--target=partmap doesn't work on whole disks.
--
Regards,
Pavel Roskin
- [PATCH] probe command, Vladimir 'phcoder' Serbinenko, 2009/06/09
- Re: [PATCH] probe command,
Pavel Roskin <=