[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix for loading modules from read-only memory area (Re: clea
From: |
Pavel Roskin |
Subject: |
Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)) |
Date: |
Thu, 25 Jun 2009 16:51:11 -0400 |
On Thu, 2009-06-25 at 22:31 +0200, Robert Millan wrote:
> You mean for efiemu? Seems fine. But I wouldn't use "target/host"
> naming, since it doesn't match with existing usage of those names
> elsewhere, which makes it very confusing.
>
> How about "native/cross"?
Fine with me. Whatever is meaningful.
> I agree there's no point in making all architectures do this. However,
> note that we'll probably see more architectures with read-only modules
> in the future (other qemu ports, but also any port where GRUB runs
> standalone).
>
> I was thinking that we could just #ifdef the symtab allocation (and the
> symtab field declaration as well). Since it's just a few lines, I think
> it'll look readable.
I'd like to avoid preprocessor conditionals in kern/ARCH/dl.c files if
possible. There is no harm in keeping mod->symtab and using it instead
of the local "symtab" variables.
--
Regards,
Pavel Roskin
- [PATCH] s/GRUB_MEMORY_MACHINE_LINK_ADDR/GRUB_KERNEL_MACHINE_LINK_ADDR/g (Re: [PATCH] i386-qemu port), (continued)
- [PATCH] s/GRUB_MEMORY_MACHINE_LINK_ADDR/GRUB_KERNEL_MACHINE_LINK_ADDR/g (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/22
- clean patch for i386-qemu port (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/22
- Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port), Pavel Roskin, 2009/06/22
- Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/23
- Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/23
- Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/23
- [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/24
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/25
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/25
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)),
Pavel Roskin <=
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Pavel Roskin, 2009/06/26
- Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)), Robert Millan, 2009/06/27