Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2

[Felix Zielcke]

Am Freitag, den 07.08.2009, 14:02 +0200 schrieb Felix Zielcke:
> Am Freitag, den 07.08.2009, 13:39 +0200 schrieb Robert Millan:
> > On Thu, Aug 06, 2009 at 11:39:11AM +0200, Felix Zielcke wrote:
> > > +    for dir in ${pkgdatadir} /boot/grub /usr/share/grub ; do
> > > +      for basename in unicode unifont ascii; do
> > > + path="${dir}/${basename}.pf2"
> > > +        if is_path_readable_by_grub ${path} > /dev/null ; then
> > > +   GRUB_FONT_PATH=${path}
> > > + else
> > > +   continue
> > > + fi
> > > + if [ "${basename}" = "ascii"] ; then
> > > +   # make sure all our children behave in conformance with ascii..
> > > +   export LANG=C
> > > + fi
> > > + break 2
> > > +      done
> > > +    done
> > > +      if [ -z "${GRUB_FONT_PATH}" ] ; then
> > > +        # fallback to the native terminal for this platform
> > > +        unset GRUB_TERMINAL_OUTPUT
> > > +      fi
> > >      fi
> > >    ;;
> > > -esac
> > > -
> > > -# does our terminal support utf-8 ?
> > > -case ${GRUB_TERMINAL_OUTPUT} in
> > > -  gfxterm) ;;
> > >    *)
> > >      # make sure all our children behave in conformance with ascii..
> > >      export LANG=C
> > > -  ;;
> > >  esac
> > 
> > It seems that "export LANG=C" is issued twice?
> > 
> Once if gfxterm gets used and once like before for all other output
> terminals.

I commited it now with an ack from Robert on IRC.


-- 
Felix Zielcke
Proud Debian Maintainer