Re: [PATCH] Improve handling of "keep" in gfxpayload

[Robert Millan]

On Mon, Aug 10, 2009 at 12:58:35PM +0100, Colin Watson wrote:
> On Mon, Aug 10, 2009 at 01:49:40PM +0200, Robert Millan wrote:
> > On Mon, Aug 10, 2009 at 12:01:02PM +0100, Colin Watson wrote:
> > > If the user set "keep" in gfxpayload, as I understand it, that indicates
> > > that they want the graphical mode set by GRUB to persist through to the
> > > kernel. In order for this to actually work with Linux, we need to set up
> > > the vid_mode boot parameter to indicate that it should keep the current
> > > video mode, otherwise it'll just reset the mode to text at boot and
> > > nothing much is gained. This patch fixes that.
> > 
> > Nice catch, I wasn't aware an extra flag was needed.
> 
> It also seems that doing this right is tricky on the kernel side (see
> https://lists.ubuntu.com/archives/kernel-team/2009-August/006773.html
> and thread), so I probably won't be turning this on by default yet in
> our configuration - but of course if you explicitly say "keep" then you
> should get what you asked for.

I read that thread.  Note that in the future, GRUB will include video
drivers, and when those are ready we don't have to use vesa, so I wouldn't
spend a lot of effort with this vesa->other video driver transition that
according to Matthew can be complicated.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."