[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] compilation with external intl library
From: |
Robert Millan |
Subject: |
Re: [PATCH] compilation with external intl library |
Date: |
Fri, 1 Jan 2010 13:00:10 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Dec 30, 2009 at 11:23:38AM +0100, Yves Blusseau wrote:
> Hi,
>
> this is the patch to "fix" compilation with external intl library. It fix the
> #28356 bug (http://savannah.gnu.org/bugs/?28356).
>
> I follow strictly the guideline of gettext, and now we can compile grub with
> external intl library.
>
> Some enhancements;
> - We can disable NLS (Native Language Support) with the --disable-nls
> configure flag.
> - We can choose where the external intl library is with the
> --with-libintl-prefix configure flag.
>
> Under linux the gettext macro detect that the gettext function is in libc and
> so don't add any flags (like before).
> On other platform like Mac OSX, the macro add the proper compile and link
> flags (ex: -lintl -liconv -lc -Wl,-framework -Wl,CoreFoundation in OSX)
>
> Best Regards,
> Yves Blusseau
>
> PS: if it ok i'll commit this patch and will add another one to make on error
> if the intl library can't be use and show alternative to compile grub.
Hi Yves,
Please can you adjust your mailer so that it marks text attachments as
text/plain? It currently sets Content-Type: application/octet-stream which
makes it hard to send a context-reply with my mailer.
I had other comments, but in particular, config.rpath shouldn't be imported
statically.
Thanks!
--
Robert Millan
"Be the change you want to see in the world" -- Gandhi
- Re: [PATCH] compilation with external intl library,
Robert Millan <=