[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] support for "elif" in grub script
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] support for "elif" in grub script |
Date: |
Fri, 26 Mar 2010 15:13:58 +0100 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20091109) |
Deepak Vankadaru wrote:
> Hi
>
> This is my patch submission after a while. I have submitted fixes for
> grub_printf in the past, which is still pending on merge conflicts.
>
grub_printf enhancements were considered unnecessary. grub_printf is
size-constrained and additional functionality is added to it only if
there is a good reason for it.
> Attached patch contains changes on top of "for-loops" branch to
> support "elif" construct in grub script. Please review and let me know
> if anything else needs to be done to get this comitted.
Looks good except absence of ChangeLog entry and that it doesn't apply
to current trunk. Can you fix those?
>
> Thanks
> Deepak
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature