[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Patch] Use absolute offset for embedding area in grub-setup (i386-pc)
From: |
Grégoire Sutre |
Subject: |
[Patch] Use absolute offset for embedding area in grub-setup (i386-pc) |
Date: |
Sat, 05 Jun 2010 02:22:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100411 Icedove/3.0.4 |
Hi,
The attached patch uses grub_partition_get_start (p) instead of p->start
in grub-setup's iteration over partitions. While we are at it, also
use grub_partition_get_len (p) instead of p->len.
An alternative would be to assume that partitions are properly nested,
and therefore iterate only over the top-level ones (i.e. those with
p->parent == NULL). In that case, we could equivalently use p->start.
In the check for non-empty embedding area, the patch uses <= instead of
== (as we may have embed_region.start == 1 && embed_region.end == 0).
Comments?
Grégoire
grub-setup.diff
Description: Text Data
- [Patch] Use absolute offset for embedding area in grub-setup (i386-pc),
Grégoire Sutre <=