[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong? |
Date: |
Mon, 07 Jun 2010 22:22:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 |
On 06/07/2010 06:58 PM, Colin Watson wrote:
> While writing documentation for booting GRUB over the network, I noticed
> that the code to handle (pxe:server_ip:gateway_ip) device names looks
> wrong. Shouldn't it be like this?
>
>
Go ahead.
> 2010-06-07 Colin Watson <address@hidden>
>
> * fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip.
>
> === modified file 'fs/i386/pc/pxe.c'
> --- fs/i386/pc/pxe.c 2010-02-14 12:18:33 +0000
> +++ fs/i386/pc/pxe.c 2010-06-07 16:56:22 +0000
> @@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di
> return err;
> if (*ptr == ':')
> {
> - err = parse_ip (ptr + 1, &(data->server_ip), 0);
> + err = parse_ip (ptr + 1, &(data->gateway_ip), 0);
> if (err)
> return err;
> }
>
> Thanks,
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature