grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use submenus for 10_linux


From: Jordan Uggla
Subject: Re: [PATCH] Use submenus for 10_linux
Date: Sun, 5 Dec 2010 00:11:54 -0800

On Sat, Dec 4, 2010 at 4:54 PM, Colin Watson <address@hidden> wrote:

> +             /* To make this work with submenus, we need to extract entries
> +                from the submenu, then return the entry number of the
> +                submenu itself if one of its entries (recursively) matches;
> +                when the submenu is executed for real, it will then have to
> +                call this function again one level down.  This is not going
> +                to be very efficient with a deep menu stack, but it seems
> +                unlikely that many people will bother with more than a
> +                couple of levels.  *

In addition to the performance impact with static submenus, this will
be completely unworkable with dynamically generated submenus. (Yes, I
can think of use cases for a saved default with a dynamically
generated submenu)

I would prefer something like:
GRUB_DEFAULT="Advanced options for Ubuntu>Ubuntu, with Linux 2.6.36.1"

Where '>' (or some other character) designates the what follows,
"Ubuntu, with Linux 2.6.36.1", is an entry within the submenu created
by selecting what precedes it, "Advanced options for Ubuntu".

Separately this also highlights an advantage of using a simplified
primary menu title (without a kernel version), as in this case if a
user wanted the default selection to be Ubuntu with the latest
installed kernel they would simply specify:
GRUB_DEFAULT="Ubuntu"

-- 
Jordan Uggla (Jordan_U on irc.freenode.net)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]