grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Reset grub_errno after embedding test on non-fatal failures


From: Mario Limonciello
Subject: [PATCH] Reset grub_errno after embedding test on non-fatal failures
Date: Mon, 26 Sep 2011 15:27:45 -0500
User-agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

Hello,

In additional MinGW testing, i've found that there are instances where the 
embedding test used in grub-setup will fail to seek on certain devices (such as 
card readers where no cards are physically present).  This sets grub_errno 
during the embedding test as the different disks in the system are tested.  It 
gets set even when installing to a different disk (all the physical disks are 
seeked).  Consequently grub_errno remains set up to the point when the core 
image is to be written out and mistakingly will indicate grub-setup failed for 
a seek error that happened at the start.

So this patch resets grub_errno while completing the embedding test only on the 
non fatal failures.

Thanks,

-- 
*Mario Limonciello*
Linux Engineer
*Dell*| OS Engineering

Attachment: errno.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]