Re: [bug] Wrong machtype argument passed for fuloong-2f

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 29.10.2011 22:54, Andreas Barth wrote:
> * David Kuehling (address@hidden) [111029 22:46]:
>> BTW it looks like it is impossible to override machtype= parameter from
>> the kernel command line configured in boot/grub/grub.cfg, since linux
>> code in loongson/common/machtype.c uses the first occurence of
>> "machtype=" in arcs_cmdline[]. Is this behaviour by design or by
>> accident?  Is this linux' fault or grub's fault?  One could change grub
>> to append machtype= rather than prepend it to the command line...
> I would consider it more appropriate to add a flag "suppress pmon
> command line" to the grub configuration - if you want to overwrite it,
> it should fully disappear, and not just be not parsed because there is
> another one first.
>
As I already said: machtype isn't only about pmon. And I consider it as
part of protocol on loongson so no, it won't be overrideable. Moreover
it's fundamentally wrong to make bugs configurable (bugs=on). Please try
the following patch:
=== modified file 'grub-core/loader/mips/linux.c'
--- grub-core/loader/mips/linux.c    2011-08-19 20:46:11 +0000
+++ grub-core/loader/mips/linux.c    2011-10-30 03:28:36 +0000
@@ -41,7 +41,7 @@
 const char loongson_machtypes[][60] =
   {
     [GRUB_ARCH_MACHINE_YEELOONG] = "machtype=lemote-yeeloong-2f-8.9inches",
-    [GRUB_ARCH_MACHINE_FULOONG2F]  = "machtype=lemote-fuloong-2f-unknown",
+    [GRUB_ARCH_MACHINE_FULOONG2F]  = "machtype=lemote-fuloong-2f-box",
     [GRUB_ARCH_MACHINE_FULOONG2E]  = "machtype=lemote-fuloong-2e-unknown"
   };
 #endif

 
> Andi
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature