Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names

[Michael Chang]

I'm cherry picking your patch into our package and will let you know
once I found any problem.

Btw, When I'm working on this, I'm not sure the *is_part = 1 should
also be set somewhere after devmapper_out: ? Please correct me if I'm
wrong.

devmapper_out:
      if (! mapper_name && node)
        {
          /* This is a DM-RAID disk, not a partition.  */
          mapper_name = dm_tree_node_get_name (node);
          if (! mapper_name)
        grub_dprintf ("hostdisk", "%s has no DM name\n", path);
        }
+     else
+       *is_part = 1;

Thanks a lot for babysitting my patch. :)

Regards,
Michael

在 2012年4月20日下午9:04，Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> 寫道：
> On 20.04.2012 13:40, Michael Chang wrote:
>> This patch fixes grub-probe fails on probing devices under
>> /dev/disk/by-id and other similar mount-by alias names. The method
>> used to determine the whole disk is by it's name without numeric
>> character end, but this may be wrong for the by-(id|uuid|path) names
>> as they are not necessary ended without numeric character. For
>> instance, my disk was named
>> "/dev/disk/by-id/ata-WDC_WD1600BEKT-60V5T1_WD-WXK0A69Y4761".
>>
>> The fix is use resolved link to kernel device names (like /dev/sda)
>> instead of these alias names.
>>
>> Downstream bug:
>> https://bugzilla.novell.com/show_bug.cgi?id=757746
>>
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>
>
> --
> Regards
> Vladimir 'φ-coder/phcoder' Serbinenko
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>