[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] '.' causes wildcard expansion
From: |
Robert Mabee |
Subject: |
Re: [PATCH] '.' causes wildcard expansion |
Date: |
Wed, 13 Jun 2012 18:42:30 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Having second thoughts. Where I suggested taking out this call
- else if (isregexop (ch))
+ else if (ch == '*') /* only wildcard currently implemented */
I should have just taken the extraneous '.' out of isregexop. That would
make it slightly simpler to add the remaining shell wildcards ('?' and '[')
when desired.
'[' already works, if there's also a * to trigger expansion, with the small
bug that special chars within [] still get escaped or translated so the set
may include an unexpected '.' or '\'.
Other regex chars also work, which probably should be counted as a
bug. I assume the eventual goal is to behave just like a common shell.