Re: [PATCH] Add gnulib's stpcpy.

[Grégoire Sutre]

On 08/05/2012 12:02 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 01.08.2012 01:26, Grégoire Sutre wrote:
>
> > The attached patch adds gnulib's stpcpy.  This is required
> > on systems lacking stpcpy, e.g., NetBSD 5.1.
>
> Where do we need it? It may make more sense to just use grub_stpcpy in
> these places.

Calls to a stpcpy appear a couple times in:

- util/grub-fstest.c
- util/grub-probe.c
- util/getroot.c        [__linux__]

I agree that using grub_stpcpy is fine there.  The benefit of importing
gnulib's stpcpy is that it solves current calls to stpcpy, as well as
the future ones (that might be added to GRUB).

There are also calls to stpcpy in:

- grub-core/lib/libgcrypt/cipher/pubkey.c
- grub-core/lib/libgcrypt/cipher/dsa.c

but they do not cause any problem (these files are not compiled afaics).

Grégoire