grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] suppress error message "/grub2/locale/en.mo.gz not found"


From: Colin Watson
Subject: Re: [PATCH] suppress error message "/grub2/locale/en.mo.gz not found"
Date: Tue, 25 Sep 2012 22:54:11 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Sep 25, 2012 at 12:46:15PM +0800, Michael Chang wrote:
> I agree with you. IMHO the problem is it's not emitted directly from
> gettext module but from common underlying fs level, removing it would
> lead to other message which is fatal be ignored as well.

That's incorrect; the gettext module is perfectly able to disregard
errors from lower-level methods that it doesn't care about.

> Another question is : Is there any other good method offered by grub2
> to check the files existence that we could test before calling
> grub_file_open() in gettext.c ? Anybody has good idea on this ?

This is the wrong approach; you should try it and then handle errors,
not look-before-you-leap.

-- 
Colin Watson                                       address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]