[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for better size handling of GRUB edit or shell
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: Patch for better size handling of GRUB edit or shell |
Date: |
Mon, 10 Dec 2012 16:15:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 |
On 07.10.2012 14:14, Dr. Tilmann Bubeck wrote:
> Hi
>
> especially on low resolution systems (e.g. VirtualBox with 800x600) the
> GRUB edit window (gfxmenu/view.c) and GRUB shell are hard to use,
> because they only use 70% of the available width, which is 800px * 70% =
> 560px. Using the borders around the view makes the window even smaller.
> Please find attached a screenshot ("grub-unchanged-640x480-editor.png")
> showing the unmodified GRUB running in gfxmode=auto which is 800x600.
> You can see, that the edit window is ridiculus small.
>
> Please find attached a patch, which changes the way, the view size is
> constructed. Before the patch it always used 70% of the available width.
> The patch checks if a full line of characters is fitting in these 70%
> and otherwise uses the available screen width, if it is not enough.
>
> You can see the result in the second screenshot
> ("grub-640x480-editor.png") attached. There is now much more room for
> the editor, without loosing the 70% style if enough space is available.
>
> Could you please apply that patch or give any feedback?
>
Patch applied after fixing its unjustified performance overhead (I
adapted the code a bit for it.
> Thanks!
>
> Tilmann Bubeck
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Patch for better size handling of GRUB edit or shell,
Vladimir 'φ-coder/phcoder' Serbinenko <=