Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

[Ilya Bakulin]

On Monday 23 September 2013 18:16:15 Vladimir 'φ-coder/phcoder' Serbinenko 
wrote:
> On 23.09.2013 17:59, Ilya Bakulin wrote:
> > Hi Vladimir,
> > So I'm preparing a OpenBSD port of GRUB2. I have chosen a revision 5152
> > for the initial version of the port.
>
> I already did couple revisions ago. After that I made further
> simplifications to multi-OS mess and it's possible that there is minor
> brokenness

Hi Vladimir,
as already discussed on IRC, by "port" I meant an entry in OpenBSD Ports 
Collection. That is like meta-information used to build a package to be 
installed later by OpenBSD package framework.

> The issue I didn't solve yet is OpenBSD using double/float in the
> headers (but you can comment out those 2 lines in Makefile.common).
Not sure which 2 lines you're talking about, currently I'm just using the 
patch you've proposed earlier (#undef double/#define double signed long).

Another issue I've found is that on OpenBSD/i386 the wrong linker format is 
used, this patch fixes that:
$ bzr diff
=== modified file 'configure.ac'
--- configure.ac        2013-09-23 11:48:10 +0000
+++ configure.ac        2013-10-07 10:57:23 +0000
@@ -655,6 +655,14 @@
       TARGET_LDFLAGS="$TARGET_LDFLAGS -Wl,-melf_x86_64_fbsd"
     fi
     ;;
+  openbsd*)
+    if test x"$target_cpu" = xi386; then
+      TARGET_LDFLAGS="$TARGET_LDFLAGS -Wl,-melf_i386_obsd"
+    fi
+    if test x"$target_cpu" = xx86_64; then
+      TARGET_LDFLAGS="$TARGET_LDFLAGS -Wl,-melf_x86_64_obsd"
+    fi
+    ;;
   *)
     if test x"$target_cpu" = xi386; then
       TARGET_LDFLAGS="$TARGET_LDFLAGS -Wl,-melf_i386"

> Other than that it should work.
> Checking out r5152 and porting it would be you duplicating my work,
> please don't.
So it makes sense for me to update to the later revision, doesn't it?
The reason why I'm asking is that I should provide an URL to download the code 
snapshot from. Currently, as there is no GRUB2 release which includes the 
OpenBSD-related patches, I have to run ./autogen, pack the tarball myself and 
put it on my server. 
> Rather help us testing, look into a way to avoid double/float for sure
> on OpenBSD and identify which other features are needed/helpful for
> OpenBSD (RAID? LFS?)
I have one more patch for cmd_loopback that I find useful for certain cases.
I will post it in the separate email later.

--
Ilya