Re: BUGS: btrfs multi-device support fixes

[Gene Czarcinski]

On 10/27/2013 11:24 AM, Andrey Borzenkov wrote:
> В Sun, 27 Oct 2013 10:47:45 -0400
> Gene Czarcinski <address@hidden> пишет:
>
> > On 10/27/2013 02:54 AM, Andrey Borzenkov wrote:
> > > В Sat, 26 Oct 2013 16:16:19 -0400
> > > Gene Czarcinski <address@hidden> пишет:
> > >
> > > > On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > > > > Rejected, similar patches is in trunk since some time.
> > > > Thanks.  I was not aware that the problem had been addressed.  Can you
> > > > point me where to look to see what has been addressed?
> > > This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed.
> > And that sure looks like something I would expect to see from a git
> > repository!
> >
> > Look, I am not stupid but I sure am confused!  The grub2 website
> > (http://www.gnu.org/software/grub/) says that all grub2 development done
> > through bazaar repository and that you get a copy of the latest grub2
> > source with: |
> >     bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub|
> > Well, I tried doing that and all I get is an error saying: "bzr: ERROR:
> > Not a branch:"
> That's where website lags behind. GRUB switched to GIT a while ago. See
>
> https://savannah.gnu.org/git/?group=grub
Thank you, thank you.  This helps a great deal.  In a way, I am not 
surprised that you switched to git as I find that most projects I 
contribute to are using git repositories and, personally, I find them 
easy to use.

Concerning the patches I submitted, if I had access to the repository 
before I submitted them, I never would have submitted them.  I would 
also have saved myself a lot of time and effort because right about the 
time this patch was added is about the time I was troubleshooting 
multi-device BTRFS.

Gene
> As for web site - I do not know; Vladimir, who can edit this?
>
> > Now fedora has a local git repository for grub2 located here:
> > git://pkgs.fedoraproject.org/grub2.git and when I look at what is there
> > I see that the updates (when they come in) appear to be in git format.
> >
> > On other little thing.  I I sent this current message there were TWO bug
> > fixes (TWO patch files).  I well believe that the first one was already
> > in trunk since I had originally reported that problem in January 2013.
> > The reason I reported it again is because it had not been pick up by fedora.
> >
> > However, there is that second bug fix which I only recently found and
> > fixed.  This problem occurs when you have /boot on BTRFS either as a
> > separate subvolume or simply as directory under the root subvolume. In
> > 10_linux, when grub2-probe is call for hint, it returns multi-device
> > hints separated by "\n" which completely screws things up.  The patch is:
> > diff --git a/util/grub-probe.c b/util/grub-probe.c
> > index a46f0b1..dd5de00 100644
> > --- a/util/grub-probe.c
> > +++ b/util/grub-probe.c
> > @@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char
> > delim)
> >              print_full_name (map, dev);
> >              printf ("' ");
> >            }
> > -      printf ("\n");
> > +      printf (" "); /* new-line causes problems for multi-device btrfs
> > volumes */
> >
> >          grub_device_close (dev);
> >          continue;