[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: conflicting types for 'grub_list_push' on MinGW (include loop)
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: conflicting types for 'grub_list_push' on MinGW (include loop) |
Date: |
Mon, 13 Jan 2014 23:00:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.2.0 |
On 13.01.2014 20:44, Andrey Borzenkov wrote:
> В Mon, 13 Jan 2014 18:33:41 +0000
> Colin Watson <address@hidden> пишет:
>
>> On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote:
>>> I'm not sure what to do here. list.h needs misc.h apparently only for
>>> definition of ATTRIBUTE_ERROR which in turn does not appear to be used
>>> anywhere else. This is not fatal so may be can be ignored for now, but
>>> still would be nice to clean up.
>>
>> Maybe we could instead move grub_strtol into grub-core/kern/misc.c,
>> after which we'd no longer need to include <grub/i18n.h> from
>> <grub/misc.h>?
>>
>
> I'd rather move compiler features into separate file (like
> grub/compiler.h) and include it from misc.h and separately from list.h.
>
This would be a good idea.
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature
Re: conflicting types for 'grub_list_push' on MinGW (include loop), Vladimir 'φ-coder/phcoder' Serbinenko, 2014/01/13