Re: [RFC PATCH 08/23] Add powerpc64 types

[Ram Pai]

On Tue, Apr 01, 2014 at 09:15:03PM +0400, Andrey Borzenkov wrote:
> В Wed, 26 Feb 2014 10:31:07 -0800
> Ram Pai <address@hidden> пишет:
> 
> > From: Anton Blanchard <address@hidden>
> > 
> >  Add powerpc64 types
> > 
> > Signed-off-by: Ram Pai <address@hidden>
> > From: Anton Blanchard <address@hidden>
> > ---
> >  include/grub/powerpc/types.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/include/grub/powerpc/types.h b/include/grub/powerpc/types.h
> > index a098ae6..7a2fc6b 100644
> > --- a/include/grub/powerpc/types.h
> > +++ b/include/grub/powerpc/types.h
> > @@ -19,11 +19,19 @@
> >  #ifndef GRUB_TYPES_CPU_HEADER
> >  #define GRUB_TYPES_CPU_HEADER      1
> >  
> > +#ifdef __powerpc64le__
> > +/* The size of void *.  */
> > +#define GRUB_TARGET_SIZEOF_VOID_P  8
> > +
> > +/* The size of long.  */
> > +#define GRUB_TARGET_SIZEOF_LONG            8
> > +#else
> >  /* The size of void *.  */
> >  #define GRUB_TARGET_SIZEOF_VOID_P  4
> >  
> >  /* The size of long.  */
> >  #define GRUB_TARGET_SIZEOF_LONG            4
> > +#endif
> >  
> >  /* powerpc is big-endian.  */
> >  #define GRUB_TARGET_WORDS_BIGENDIAN        1
> 
> This sure can't be right on LE platform?


I have it updated later in the patch series. I think
it is better to merge that patch with this one.


BTW:  I have a new patch series, which simplifies the build,
and takes out lot of duplication. Will send that out soon.


Thanks,

-- 
Ram Pai