Re: [PATCH] grub-core/lib/libgcrypt/cipher/rijndael.c 2 warnings.

[Toomas Soome]

hi!

just checked the  git://git.gnupg.org/libgcrypt.git - apparently it has been 
changed compared to one included in grub; the int i versus unsigned keylen is 
still there (visual inspection), the { }  were inserted to if (0) ; statement. 

so second half is already fixed.  I did report the signed/unsigned compare 
issue to gcrypt-devel, but then the question is about updating libcgrypt in 
grub; the reason I have posted this fix is to get warnings cleared to make 
illumos build system happy with as little local fixes as possible… well, of 
course i can just keep this commit in my local branch anyhow.

btw, I also have rather large update in queue, zfs module rework. I suppose its 
not good idea directly to list, are there alternative ways?

rgds,
toomas


> On 13.04.2015, at 19:56, Andrei Borzenkov <address@hidden> wrote:
> 
> В Mon, 13 Apr 2015 13:47:11 +0300
> Toomas Soome <address@hidden> пишет:
> 
>> 
>> hi!
>> 
>> first warning is about comparing signed int with unsigned (int i, unsigned 
>> keylen), second warning is suggesting to use { } around the block.
>> 
>> after this update, the grub-core/lib/libgcrypt-grub needs to be re-populated.
>> 
>> rgds,
>> toomas
>> 
> 
> well, this is is external project and policy is normally to fix such
> issues upstream. Could you check if this is fixed in current libgcrypt?
> If not could you report it there?