grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: multiboot2.h & multiboot_header_tag_module_align


From: Toomas Soome
Subject: Re: multiboot2.h & multiboot_header_tag_module_align
Date: Thu, 04 Jun 2015 19:04:46 +0300

> On 04.06.2015, at 18:31, Vladimir 'φ-coder/phcoder' Serbinenko 
> <address@hidden> wrote:
> 
> On 04.06.2015 14:18, Toomas Soome wrote:
>> hi!
>> 
>> i know this tag (multiboot_header_tag_module_align) is not really used, but 
>> it still would be nice if the copy/paste error of the actual structure would 
>> be fixed;)
>> 
> Can you propose a patch?
>> rgds,

as its header tag, i think following should be it; header tags have 16bit ints 
for type and flags, 32bit size and based on name, this tag is to request 
bootloader to use specified alignment, so the data field should be 32bit uint 
as well (default MULTIBOOT_MOD_ALIGN is 0x00001000).

diff --git a/include/multiboot2.h b/include/multiboot2.h
index 3ccff15..e3064da 100644
--- a/include/multiboot2.h
+++ b/include/multiboot2.h
@@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align
   multiboot_uint16_t type;
   multiboot_uint16_t flags;
   multiboot_uint32_t size;
-  multiboot_uint32_t width;
-  multiboot_uint32_t height;
-  multiboot_uint32_t depth;
+  multiboot_uint32_t align;
 };
 
 struct multiboot_color





reply via email to

[Prev in Thread] Current Thread [Next in Thread]