Re: [PATCH] Use UEFI Time Service to calibrate TSC

[Michael Chang]

On Thu, Nov 12, 2015 at 11:52:24AM +0300, Andrei Borzenkov wrote:
> On Thu, Nov 12, 2015 at 10:34 AM, Michael Chang <address@hidden> wrote:
> > On Mon, Nov 09, 2015 at 03:21:37PM +0100, Vladimir 'φ-coder/phcoder' 
> > Serbinenko wrote:
> >> On 09.11.2015 14:23, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> >> > On 09.11.2015 09:03, Michael Chang wrote:
> >
> >> Attached proof-of-concept. It's all in one file but different methods
> >> should probably go in separate files.
> >
> > Hi Vladmir,
> >
> > Thanks for your guidence to the better fix. I built your patch with
> > attach patch on top of yours to fix the errors found in our build
> > service and also some other affected platforms which might also need the
> > similar fix.
> >
> 
> Why did you need to move i386-pc ACPI files to core? They are used by
> acpi module only anyway, so there is no logical reason to do it?

Because Vladimir's prototype patch has been moved them.

 +  i386_coreboot = kern/i386/pc/acpi.c;
 +  i386_multiboot = kern/i386/pc/acpi.c;
 +  i386_coreboot = kern/acpi.c;
 +  i386_multiboot = kern/acpi.c;

My patch was just intended to fix build error and test, Looking into the
patch it seems needed by coreboot. I could't tell much that
GRUB_MACHINE_MULTIBOOT is missed by accident or not in his patch.

 +#elif defined (GRUB_MACHINE_COREBOOT)
 +      (void) (calibrate_tsc_pmtimer() || calibrate_tsc_pit () ||
calibrate_tsc_hardcode());
 +#else

Thanks,
Michael