Re: [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

[Andrei Borzenkov]

26.02.2016 14:13, address@hidden пишет:
> From: Fu Wei <address@hidden>
> 
> delete: xen_linux, xen_initrd, xen_xsm
> add: xen_module
> 
> This update bases on
>     commit 0edd750e50698854068358ea53528100a9192902
>     Author: Vladimir Serbinenko <address@hidden>
>     Date:   Fri Jan 22 10:18:47 2016 +0100
> 
>         xen_boot: Remove obsolete module type distinctions.
> 
> Signed-off-by: Fu Wei <address@hidden>
> ---
>  docs/grub.texi | 33 ++++++++++-----------------------
>  1 file changed, 10 insertions(+), 23 deletions(-)
> 
> diff --git a/docs/grub.texi b/docs/grub.texi
> index 82f6fa4..3fbdd99 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -3861,9 +3861,7 @@ you forget a command, you can run the command 
> @command{help}
>  * videoinfo::                   List available video modes
>  @comment * xen_*::              Xen boot commands
>  * xen_hypervisor::              Load xen hypervisor binary
> -* xen_linux::                   Load dom0 kernel for xen hypervisor
> -* xen_initrd::                  Load dom0 initrd for dom0 kernel
> -* xen_xsm::                     Load xen security module for xen hypervisor
> +* xen_module::                  Load xen modules for xen hypervisor
>  @end menu
>  
>  
> @@ -5141,30 +5139,19 @@ verbatim as the @dfn{kernel command-line}. Any other 
> binaries must be
>  reloaded after using this command.
>  @end deffn
>  
> address@hidden xen_linux
> address@hidden xen_linux
> address@hidden xen_module
> address@hidden xen_module
>  
> address@hidden Command xen_linux file [arguments]
> -Load a dom0 kernel image for xen hypervisor at the booting process of xen.
> address@hidden Command xen_module [--nounzip] file [arguments]
> +Load a module for xen hypervisor at the booting process of xen.
>  The rest of the line is passed verbatim as the module command line.

==
> +On i386,  the modules will be identified by Multiboot(2) protocol.
> +On arm64, each module will be identified by the order in which the
> +modules are added.

I think it is better to skip it entirely. It is not really correct -
neither multiboot protocol provides any module identification (Xen
probes module types), nor is i386 using multiboot2, nor can all modules
be probed, so order still matters. To avoid confusion I'd simply
replaced the above three lines with

Modules should be loaded in the following order:

> +The 1st module: dom0 kernel image
> +The 2nd module: dom0 ramdisk (optional)

This covers both supported platforms without going into too deep
details; if you and Vladimir are OK, I'll commit with this change.

>  @end deffn
>  
> address@hidden xen_initrd
> address@hidden xen_initrd
> -
> address@hidden Command xen_initrd file
> -Load a initrd image for dom0 kernel at the booting process of xen.
> address@hidden deffn
> -
> address@hidden xen_xsm
> address@hidden xen_xsm
> -
> address@hidden Command xen_xsm file
> -Load a xen security module for xen hypervisor at the booting process of xen.
> -See @uref{http://wiki.xen.org/wiki/XSM} for more detail.
> address@hidden deffn
> -
> -
>  @node Networking commands
>  @section The list of networking commands
>  
>