grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] http: fix superfluous null line in range request header


From: Andrei Borzenkov
Subject: Re: [PATCH] http: fix superfluous null line in range request header
Date: Sat, 9 Apr 2016 07:08:58 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

06.04.2016 13:19, Michael Chang пишет:
> At least the apache sever is very unhappy with that extra null line and will
> take more than ten seconds in responding to each range request, which slows
> down a lot the entire http file transfer process or even time out.

Applied. Thanks!

> ---
>  grub-core/net/http.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/grub-core/net/http.c b/grub-core/net/http.c
> index 4684f8b..a7c5101 100644
> --- a/grub-core/net/http.c
> +++ b/grub-core/net/http.c
> @@ -381,9 +381,8 @@ http_establish (struct grub_file *file, grub_off_t 
> offset, int initial)
>        ptr = nb->tail;
>        grub_snprintf ((char *) ptr,
>                    sizeof ("Range: bytes=XXXXXXXXXXXXXXXXXXXX-"
> -                          "\r\n"
>                            "\r\n"),
> -                  "Range: bytes=%" PRIuGRUB_UINT64_T "-\r\n\r\n",
> +                  "Range: bytes=%" PRIuGRUB_UINT64_T "-\r\n",
>                    offset);
>        grub_netbuff_put (nb, grub_strlen ((char *) ptr));
>      }
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]