grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: powerpc-ieee1275 and grub-mkfont dependency


From: Andrei Borzenkov
Subject: Re: powerpc-ieee1275 and grub-mkfont dependency
Date: Thu, 10 Nov 2016 16:53:23 +0300

I do not like it, sorry. If this platform supports framebuffer we
should build grub with framebuffer. If you do not (want to) use it -
fine, nobody forces you to do it. But on this path we get
proliferation of slightly different incompatible binaries in the wild.

On Thu, Nov 10, 2016 at 12:52 AM, Aaro Koskinen <address@hidden> wrote:
> Hi,
>
> On Wed, Nov 09, 2016 at 07:46:54PM +0100, Daniel Kiper wrote:
>> On Wed, Nov 09, 2016 at 12:23:59AM +0200, Aaro Koskinen wrote:
>> > When upgrading from 2.00 to 2.02~beta3, I noticed that on powerpc it's
>> > no longer possible to build with --disable-grub-mkfont: ./configure
>> > forces it and complains about missing fontconfig etc.
>> >
>> > However, when I delete those checks from the configure script, I'm able
>> > to build and install a working bootloader for my G4 & G5 Macs (with the
>> > same functionality as with 2.00, using either OF console or serial).
>> >
>> > So I think those configure checks should be relaxed. I think it's overkill
>> > to require fontconfig etc. stuff just to build a serial console bootloader
>> > for G5 server.
>>
>> No problem. Could you send us a fix for this issue?
>
> I'm using the below patch.
>
> A.
>
> ---8<---
>
> From beb8ca2c32e1720686a476b61d492ad2b5ed2c3a Mon Sep 17 00:00:00 2001
> From: Aaro Koskinen <address@hidden>
> Date: Wed, 9 Nov 2016 23:26:43 +0200
> Subject: [PATCH] configure.ac: don't require build time grub-mkfont on
>  powerpc-ieee1275
>
> Don't require build time grub-mkfont on powerpc-ieee1275.
>
> Signed-off-by: Aaro Koskinen <address@hidden>
> ---
>  configure.ac | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 9ddfc53..3d25510 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1555,11 +1555,11 @@ if test x"$grub_build_mkfont_excuse" = x ; then
>  else
>    enable_build_grub_mkfont=no
>  fi
> -if test x"$enable_build_grub_mkfont" = xno && ( test "x$platform" = xqemu || 
> test "x$platform" = xloongson || test "x$platform" = xqemu_mips || test 
> "x$target_cpu"-"$platform" = xpowerpc-ieee1275 || test "x$platform" = 
> xcoreboot ); then
> +if test x"$enable_build_grub_mkfont" = xno && ( test "x$platform" = xqemu || 
> test "x$platform" = xloongson || test "x$platform" = xqemu_mips || test 
> "x$platform" = xcoreboot ); then
>    if test x"$grub_build_mkfont_excuse" = x ; then
> -    AC_MSG_ERROR([qemu, powerpc-ieee1275, coreboot and loongson ports needs 
> build-time grub-mkfont])
> +    AC_MSG_ERROR([qemu, coreboot and loongson ports need build-time 
> grub-mkfont])
>    else
> -    AC_MSG_ERROR([qemu, powerpc-ieee1275, coreboot and loongson ports needs 
> build-time grub-mkfont ($grub_build_mkfont_excuse)])
> +    AC_MSG_ERROR([qemu, coreboot and loongson ports need build-time 
> grub-mkfont ($grub_build_mkfont_excuse)])
>    fi
>  fi
>
> @@ -1629,11 +1629,11 @@ if test x"$enable_build_grub_mkfont" = xno ; then
>    FONT_SOURCE=
>  fi
>
> -if test "x$FONT_SOURCE" = x && ( test "x$platform" = xqemu || test 
> "x$platform" = xloongson || test "x$platform" = xqemu_mips || test 
> "x$target_cpu"-"$platform" = xpowerpc-ieee1275 || test "x$platform" = 
> xcoreboot ); then
> +if test "x$FONT_SOURCE" = x && ( test "x$platform" = xqemu || test 
> "x$platform" = xloongson || test "x$platform" = xqemu_mips || test 
> "x$platform" = xcoreboot ); then
>    if test x"$grub_build_mkfont_excuse" = x ; then
> -    AC_MSG_ERROR([qemu, powerpc-ieee1275, coreboot and loongson ports need 
> unifont])
> +    AC_MSG_ERROR([qemu, coreboot and loongson ports need unifont])
>    else
> -    AC_MSG_ERROR([qemu, powerpc-ieee1275, coreboot and loongson ports need 
> unifont ($grub_build_mkfont_excuse)])
> +    AC_MSG_ERROR([qemu, coreboot and loongson ports need unifont 
> ($grub_build_mkfont_excuse)])
>    fi
>  fi
>
> --
> 2.9.2
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]